test(spanner): speed up test with emulator #8072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rpc_failure_threshold_integration_test` was running very slowly against the emulator. The test is not that useful against the emulator, but we do not want it to rot. I changed the test to detect that it is running against the emulator, and then simply reduce the running time, and ignore the statistical results as they become unreliable.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8072 +/- ##
==========================================
- Coverage 94.88% 94.88% -0.01%
==========================================
Files 1310 1310
Lines 118068 118070 +2
==========================================
- Hits 112034 112030 -4
- Misses 6034 6040 +6
Continue to review full report at Codecov.
|
devbww
approved these changes
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rpc_failure_threshold_integration_testwas running very slowlyagainst the emulator. The test is not that useful against the emulator,
but we do not want it to rot. I changed the test to detect that it is
running against the emulator, and then simply reduce the running time, and
ignore the statistical results as they become unreliable.
Motivated by #4039
This change is