Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): introduce MockDataConnection and MakeRowReader #9335

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 23, 2022

Part of the work for #8860

this moves our two mock/test classes out of the internal namespace.

We also drop "Test" from the helper name to be consistent with spanner_mocks::MakeRow(...):

inline spanner::Row MakeRow(


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 23, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 051c149791d01c27fc82f0316c897d762ed09af4

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #9335 (0673b95) into main (0673b95) will not change coverage.
The diff coverage is n/a.

❗ Current head 0673b95 differs from pull request most recent head 051c149. Consider uploading reports for the commit 051c149 to get more accurate results

@@           Coverage Diff           @@
##             main    #9335   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files        1470     1470           
  Lines      134793   134793           
=======================================
  Hits       127603   127603           
  Misses       7190     7190           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0673b95...051c149. Read the comment docs.

@dbolduc dbolduc marked this pull request as ready for review June 23, 2022 05:15
@dbolduc dbolduc requested a review from a team as a code owner June 23, 2022 05:15
@dbolduc dbolduc merged commit ef07607 into googleapis:main Jun 23, 2022
@dbolduc dbolduc deleted the bigtable-modern-mocks branch June 23, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants