test(storage): more tweaks to ranged reads #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benchmark would perform a range read with 50% probability, but some ranged reads were "full" as the range was larger than the object. I found it hard to reason about this, so now only the range size controls whether the read is full or not. I also rediscovered a quirk of the JSON API, that it is better avoided: reading the last 0 bytes actually returns all the bytes. Maybe we should fix this in the client library itself, for now just avoid running into it.
product-auto-label
bot
added
the
api: storage
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9400 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 1485 1485
Lines 136008 136008
=======================================
+ Hits 128672 128674 +2
+ Misses 7336 7334 -2
Continue to review full report at Codecov.
|
devbww
reviewed
Jul 1, 2022
google/cloud/storage/benchmarks/storage_throughput_vs_cpu_benchmark.cc
Outdated
Show resolved
Hide resolved
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devbww
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark would perform a range read with 50% probability, but some
ranged reads were "full" as the range was larger than the object. I
found it hard to reason about this, so now only the range size controls
whether the read is full or not.
I also rediscovered a quirk of the JSON API, that it is better avoided:
reading the last 0 bytes actually returns all the bytes. Maybe we should
fix this in the client library itself, for now just avoid running into
it.
This change is