Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): modern Table constructor #9403

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 30, 2022

Fixes #8860
Technically this fixes #6465 which fixes #1161. Although we should probably update our credentials sample. (I think of that task as #7434).

Release the Table constructor that accepts a DataConnection. Yay, we are close to having a good mocking story. and a good credentials story. (I say close because there is still the pesky legacy API which does not have these things and lives alongside the "new shinny").

For now I just list the relevant options in the constructor's documentation. I would like to link to examples of how the Options are used. But the examples must exist first. (#9309 tracks this work).

I would also like to provide guidance on how to mock the Table calls in this constructor's documentation. (which is blocked on #9308).

I think this feature warrants a detailed CHANGELOG entry, but I am going to wait until the other modernization work is done before writing the post.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 30, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 7f75d607b6c06db4b167c43997208a6bc95ee1b9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #9403 (f2db272) into main (28610e6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9403   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files        1485     1485           
  Lines      136006   136008    +2     
=======================================
+ Hits       128669   128677    +8     
+ Misses       7337     7331    -6     
Impacted Files Coverage Δ
google/cloud/bigtable/table.h 98.42% <100.00%> (-0.06%) ⬇️
google/cloud/bigtable/table_test.cc 100.00% <100.00%> (ø)
...e/cloud/bigtable/testing/table_integration_test.cc 80.87% <100.00%> (+0.21%) ⬆️
...ogle/cloud/bigtable/tests/data_integration_test.cc 97.72% <100.00%> (ø)
...gtable/tests/table_sample_rows_integration_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/curl_impl.cc 91.87% <0.00%> (+0.22%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+0.58%) ⬆️
...loud/bigtable/internal/connection_refresh_state.cc 100.00% <0.00%> (+2.77%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28610e6...f2db272. Read the comment docs.

@dbolduc dbolduc marked this pull request as ready for review June 30, 2022 21:59
@dbolduc dbolduc requested a review from a team as a code owner June 30, 2022 21:59
@dbolduc dbolduc force-pushed the bigtable-modern-table-ctor branch from 7f75d60 to f2db272 Compare July 1, 2022 03:54
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f2db272cfc5d49721713a19158a22d9600d51a3f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc
Copy link
Member Author

dbolduc commented Jul 1, 2022

/gcbrun

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f2db272cfc5d49721713a19158a22d9600d51a3f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc
Copy link
Member Author

dbolduc commented Jul 1, 2022

Another build failed to trigger. We go again.

@dbolduc
Copy link
Member Author

dbolduc commented Jul 1, 2022

/gcbrun

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f2db272cfc5d49721713a19158a22d9600d51a3f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc
Copy link
Member Author

dbolduc commented Jul 1, 2022

oh duh, because the trigger is disabled...

@dbolduc
Copy link
Member Author

dbolduc commented Jul 1, 2022

/gcbrun

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f2db272cfc5d49721713a19158a22d9600d51a3f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc merged commit dfd5283 into googleapis:main Jul 1, 2022
@dbolduc dbolduc deleted the bigtable-modern-table-ctor branch July 1, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
3 participants