Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(asset): reenable on macOS #9468

Merged
merged 2 commits into from
Jul 18, 2022
Merged

fix(asset): reenable on macOS #9468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81ad452
fix(asset): reenable on macOS
dbolduc Jul 13, 2022
0280216
windows bazel still disabled
dbolduc Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions google/cloud/asset/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ cc_library(
include = [HEADER_GLOB],
exclude = [MOCK_HEADER_GLOB],
),
# TODO(#8145): Enable on macOS and windows.
# TODO(#8145): Enable on windows.
target_compatible_with = select({
"@platforms//os:macos": ["@platforms//:incompatible"],
"@platforms//os:windows": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
Expand Down
10 changes: 0 additions & 10 deletions google/cloud/asset/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,6 @@
# limitations under the License.
# ~~~

# TODO(8145): Enable on macOS.
if (APPLE)
message(
WARNING
"Cannot build google/cloud/asset on Apple platforms."
" More details at https://github.com/googleapis/google-cloud-cpp/issues/8145 ."
)
return()
endif ()

include(GoogleapisConfig)
set(DOXYGEN_PROJECT_NAME "Cloud Asset API C++ Client")
set(DOXYGEN_PROJECT_BRIEF "A C++ Client Library for the Cloud Asset API")
Expand Down