feat(storage): add debugging headers to ObjectWriteStream
#9580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it easier to troubleshoot problems with resumable uploads (aka `Client::WriteObject()`) by capturing the headers of the last request. We do not want to capture the headers for all the requests because there can be an unbounded number of requests, and therefore all the headers can consume arbitrary amounts of memory.
product-auto-label
bot
added
the
api: storage
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9580 +/- ##
=======================================
Coverage 94.36% 94.36%
=======================================
Files 1491 1491
Lines 137591 137586 -5
=======================================
- Hits 129839 129836 -3
+ Misses 7752 7750 -2
Continue to review full report at Codecov.
|
scotthart
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to troubleshoot problems with resumable uploads (aka
Client::WriteObject()) by capturing the headers of the last request.We do not want to capture the headers for all the requests because there
can be an unbounded number of requests, and therefore all the headers
can consume arbitrary amounts of memory.
This change is