Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: video, baremetalsolution, and optimization are GA #9704

Merged
merged 3 commits into from
Aug 18, 2022
Merged

doc: video, baremetalsolution, and optimization are GA #9704

merged 3 commits into from
Aug 18, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Aug 18, 2022 •
edited
Loading

This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 8defc16352d894e0ee8ac7c6913c6017002fe867

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Aug 18, 2022 •
edited
Loading

Codecov Report

Merging #9704 (71393b2) into main (ab44cf3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9704   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files        1496     1496           
  Lines      139303   139303           
=======================================
+ Hits       130796   130800    +4     
+ Misses       8507     8503    -4
Impacted Files Coverage Δ
...e/cloud/spanner/testing/cleanup_stale_instances.cc 72.22% <0.00%> (-5.56%) ⬇️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.15% <0.00%> (+0.16%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 84.86% <0.00%> (+0.65%) ⬆️
...te/integration_tests/publisher_integration_test.cc 98.68% <0.00%> (+6.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coryan coryan marked this pull request as ready for review August 18, 2022 15:58
@coryan coryan requested a review from a team as a code owner August 18, 2022 15:58
devbww
devbww reviewed Aug 18, 2022
View reviewed changes
google/cloud/baremetalsolution/README.md Outdated
@@ -1,14 +1,12 @@
# Bare Metal Solution API C++ Client Library

:construction:

[Bare Metal Solution API][cloud-service-root], a service that provides ways to
manage Bare Metal Solution hardware installed in a regional extension located
near a Google Cloud data center.

This library is **experimental**. Its APIs are subject to change without notice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

experimental?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

google/cloud/baremetalsolution/doc/main.dox Outdated
This library is **experimental**. Its APIs are subject to change without notice.
While this library is **GA**, please note Google Cloud C++ client libraries do
**not** follow [Semantic Versioning](https://semver.org/). Its APIs are subject
to change without notice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"subject to change without notice"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixedf

google/cloud/optimization/README.md Outdated
@@ -1,14 +1,12 @@
# Cloud Optimization API C++ Client Library

:construction:

This directory contains an idiomatic C++ client library for the
[Cloud Optimization API][cloud-service-root], a service that provides a
portfolio of solvers to address common optimization use cases.

This library is **experimental**. Its APIs are subject to change without notice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

experimental?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

google/cloud/optimization/doc/main.dox Outdated
This library is **experimental**. Its APIs are subject to change without notice.
While this library is **GA**, please note Google Cloud C++ client libraries do
**not** follow [Semantic Versioning](https://semver.org/). Its APIs are subject
to change without notice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"subject to change without notice"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

google/cloud/video/doc/main.dox Outdated
This library is **experimental**. Its APIs are subject to change without notice.
While this library is **GA**, please note Google Cloud C++ client libraries do
**not** follow [Semantic Versioning](https://semver.org/). Its APIs are subject
to change without notice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"subject to change without notice"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

dbolduc
dbolduc reviewed Aug 18, 2022
View reviewed changes
CHANGELOG.md Outdated
Comment on lines 144 to 147
* [Video Services](/google/cloud/video/README.md)
* [Bare Metal Solution](/google/cloud/baremetalsolution/README.md)
* [Optimization AI](/google/cloud/optimization/README.md)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: order these alphabetically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
@@ -261,6 +267,9 @@ This repository contains idiomatic C++ client libraries for the following
* [Cloud Translation API](google/cloud/translate/README.md)
[[quickstart]](google/cloud/translate/quickstart/README.md)
[[reference]](https://googleapis.dev/cpp/google-cloud-translate/latest)
* [Transcoder API](google/cloud/video/README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, this is weird because there is also "Live Stream API" and "Video Stitcher API" in google/cloud/video/.

I see that google/cloud/video/README.md says this is the "Transcoder API C++ Client Library"... I am inclined to break the "Foo API" mold and instead say "Video Services" here and in the README....

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 9f4b0bba0582cf4347caf1dff1d84ea322c37a07

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 71393b2a5a3a765c9af3c752a7077505a493fab7

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 1abf599 into googleapis:main Aug 18, 2022
@coryan coryan deleted the chore-declare-libraries-GA branch August 18, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

@dbolduc dbolduc dbolduc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coryan @google-cloud-cpp-bot @devbww @dbolduc