-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unflake TestIntegration_UpdateRetentionPolicy #1632
Comments
Updates #1632 Change-Id: I78ec1c77d27e129ae4053ed0c5f10909bb3df263 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/47270 Reviewed-by: Chris Cotter <cjcotter@google.com>
I believe the error exorcises the problem in I think what we can do is: That'll ensure that the retention policy conditions are set to the same level playing field for each test and then also sleep for a bit after each subTest runs since the quota for bucket updates is 1 per second. |
I've mailed https://code-review.googlesource.com/c/gocloud/+/55031 to deflake this test. |
…ucket use" This reverts commit fff13f4. Reason for revert: This integration test consistently fails in Kokoro when re-enabled. Need to debug failure before merging again. === RUN TestIntegration_UpdateRetentionPolicy TestIntegration_UpdateRetentionPolicy: integration_test.go:2641: input: <nil> got=-, want=+: (*storage.RetentionPolicy)( - nil, + &{RetentionPeriod: s"1m0s"}, ) --- FAIL: TestIntegration_UpdateRetentionPolicy (7.98s) Updates #1959 Updates #1632 Change-Id: I550a971dcd569f45ace508f56dc928ab38f2a19d Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/55410 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Cody Oss <codyoss@google.com>
Fix didn't work correctly in Kokoro:
Reverted and re-opening this issue. |
This test was skipped b/c of a rate limit issue, but we were able to waive this rate limit for the testing project via an internal change. Fixes googleapis#1632
This test was skipped b/c of a rate limit issue, but we were able to waive this rate limit for the testing project via an internal change. Fixes #1632
This test was skipped b/c of a rate limit issue, but we were able to waive this rate limit for the testing project via an internal change. Fixes googleapis#1632
https://sponge.corp.google.com/target?id=a8d868bf-56bf-4ede-972f-48bbf660a9ba&target=cloud-go-libraries/google-cloud-go/continuous/go112&searchFor=&show=ALL&sortBy=STATUS
The text was updated successfully, but these errors were encountered: