-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: unflake TestIntegration_RequesterPays #1753
Labels
api: storage
Issues related to the Cloud Storage API.
type: cleanup
An internal cleanup or hygiene concern.
Comments
tritone
added
triage me
I really want to be triaged.
api: storage
Issues related to the Cloud Storage API.
type: cleanup
An internal cleanup or hygiene concern.
and removed
triage me
I really want to be triaged.
labels
Jan 27, 2020
@IlyaFaer or @AlisskaPie could you take this on? |
@tritone we take it |
Thanks! I'm going to put in a skip for now because it has been flaking frequently. |
gopherbot
pushed a commit
that referenced
this issue
Jan 30, 2020
This test has been flaking frequently; there is an issue open to fix. Updates #1753 Change-Id: I6210b67a154ea77085003846e04f7e36c28b07cc Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/51210 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>
AlisskaPie
added a commit
to MaxxleLLC/google-cloud-go
that referenced
this issue
Jun 11, 2020
Using unique object name for every operation to fix flakey Fixes googleapis#1753 Change-Id: I1971183a6d55db38b6a30e1be94f1139f57aa565
tritone
added a commit
to tritone/google-cloud-go
that referenced
this issue
Jan 23, 2021
Use an additional object for the ACL section of the test to avoid rate limit flakes. Fixes googleapis#1753
tritone
added a commit
that referenced
this issue
Jan 26, 2021
* test(storage): Unflake TestIntegration_RequesterPays Use an additional object for the ACL section of the test to avoid rate limit flakes. Fixes #1753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the Cloud Storage API.
type: cleanup
An internal cleanup or hygiene concern.
Multiple flakes in the past week:
https://sponge.corp.google.com/target?id=3c0d95d4-29b3-4d0d-8953-0423aa0d7536&target=cloud-devrel/client-libraries/go/google-cloud-go/continuous/go113&searchFor=&show=ALL&sortBy=STATUS
https://sponge.corp.google.com/target?id=a1194c56-fd86-427a-8121-6393e31895f4&target=cloud-devrel/client-libraries/go/google-cloud-go/continuous/go112&searchFor=&show=ALL&sortBy=STATUS
Looks like we need to introduce a short delay or retry here due to rate limits.
The text was updated successfully, but these errors were encountered: