Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage/transfermanager): WaitAndClose waits for Callbacks to finish #10504

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix(storage/transfermanager): WaitAndClose waits for Callbacks to finish #10504

merged 2 commits into from
Jul 3, 2024

Conversation

BrennaEpp
Copy link
Contributor

Fixes #10502

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jul 3, 2024
@BrennaEpp BrennaEpp marked this pull request as ready for review July 3, 2024 19:04
@BrennaEpp BrennaEpp requested review from a team as code owners July 3, 2024 19:04
tritone
tritone approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@BrennaEpp BrennaEpp merged commit 0e81002 into googleapis:main Jul 3, 2024
8 checks passed
This was referenced Jul 3, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@release-please release-please bot mentioned this pull request Jul 3, 2024
Merged
@BrennaEpp BrennaEpp deleted the tm-fix branch July 9, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage/transfermanager: TestIntegration_DownloaderSynchronous failed
2 participants
@BrennaEpp @tritone