Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): Publish settings and errors #3075

Merged
merged 9 commits into from
Oct 28, 2020

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Oct 23, 2020

PublishSettings are almost identical to pubsub.PublishSettings.

Some max thresholds were changed to be consistent with the Pub/Sub Lite Java client library.

@tmdiep tmdiep requested a review from a team as a code owner October 23, 2020 00:24
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2020
@tmdiep tmdiep requested a review from hongalex October 23, 2020 00:25
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Oct 23, 2020
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will defer to Alex

pubsublite/settings.go Show resolved Hide resolved
pubsublite/settings_test.go Show resolved Hide resolved
@tmdiep tmdiep requested a review from hongalex October 27, 2020 19:38
@tmdiep tmdiep merged commit 9eb9fcb into googleapis:master Oct 28, 2020
@tmdiep tmdiep deleted the publish_settings branch October 28, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants