Fix typing - :type kwargs: dict
is not correct
#7422
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When typing Python code, the special
*args
and**kwargs
params are typed based on their contents, not what they actually are (a tuple, and a dict) e.g.And in this case, the types are passed to a different func (
Query.__init__
) which has specific arguments, so it is best to not give **kwargs a type, or, better, copy the parameters of that function (but I haven't done this here).This also applies to
Transaction
.PS I know this is a stupidly minor change but it annoys me, having to write
noinspection PyTypeChecker
before every datastore query.😄