-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage: ensure that 'Blob.reload' passes encryption headers. #7441
Storage: ensure that 'Blob.reload' passes encryption headers. #7441
Conversation
Use it when reloading the instance.
Override to use the blob's '_encryption_key' attribute. Closes #7440.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this will allow a .reload() on an encrypted object. Though, I do want to ask if it's reasonable to apply _encryption_headers() check to even buckets given they're not valid.
Future us may ask why it's being used for buckets as well.
@frankyn The |
Thanks @tseaver, could you add a comment near the method stating that it's primary use is for a Blob and the given use case? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated Firestore failure is from a known-flaky systest, see #7130. |
Closes #7440.