Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: add 'Client.list_hmac_keys' method. #8043

Merged
merged 3 commits into from
May 29, 2019
Merged

Storage: add 'Client.list_hmac_keys' method. #8043

merged 3 commits into from
May 29, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 20, 2019 •
edited
Loading

Incorporates commits from #8042.

Toward #7851.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 20, 2019
@tseaver tseaver requested a review from jkwlui May 20, 2019 20:17
@tseaver tseaver requested a review from crwilcox as a code owner May 20, 2019 20:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@jkwlui jkwlui mentioned this pull request May 20, 2019
Closed
8 tasks
@tseaver
Copy link
Contributor Author

tseaver commented May 20, 2019

Unrelated dataproc and scheduler failures due to Kokoro-internal glitch.

@tseaver
Copy link
Contributor Author

tseaver commented May 21, 2019

Rebased after merge of #8041 to the feature branch.

@tseaver tseaver mentioned this pull request May 23, 2019
Closed
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2019
jkwlui
jkwlui approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@jkwlui jkwlui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surface looks good!

@tseaver tseaver merged commit 66accf6 into googleapis:storage-add-hmac-key-support-feature May 29, 2019
@tseaver tseaver deleted the 7851-storage-add-client-list_hmac_keys branch May 29, 2019 15:49
@plamut plamut mentioned this pull request Jun 12, 2019
Merged
tseaver added a commit that referenced this pull request Jun 19, 2019
@tseaver
Add 'list_hmac_keys' / 'create_hmac_key' methods to client. (#8043)
c07dbab 
Toward #7851.
@tseaver tseaver mentioned this pull request Jun 19, 2019
Merged
1 task
tseaver added a commit that referenced this pull request Jun 26, 2019
@tseaver
Add 'list_hmac_keys' / 'create_hmac_key' methods to client. (#8043)
0e0b67e 
Toward #7851.
tseaver added a commit that referenced this pull request Jul 2, 2019
@tseaver
Add 'list_hmac_keys' / 'create_hmac_key' methods to client. (#8043)
8fbb465 
Toward #7851.
tseaver added a commit that referenced this pull request Jul 2, 2019
@tseaver
Add 'list_hmac_keys' / 'create_hmac_key' methods to client. (#8043)
eec8855 
Toward #7851.
tseaver added a commit that referenced this pull request Jul 9, 2019
@tseaver
Add 'list_hmac_keys' / 'create_hmac_key' methods to client. (#8043)
a36ceb7 
Toward #7851.
tseaver added a commit that referenced this pull request Jul 9, 2019
@tseaver
Add 'list_hmac_keys' / 'create_hmac_key' methods to client. (#8043)
ef6afea 
Toward #7851.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwlui jkwlui jkwlui approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @jkwlui @googlebot @yoshi-kokoro