Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods. #8045

Merged
merged 5 commits into from
Jun 19, 2019
Merged

Storage: Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods. #8045

merged 5 commits into from
Jun 19, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 20, 2019 •
edited
Loading

Uses #8041 as a base.

Toward #7851.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 20, 2019
@tseaver tseaver requested a review from jkwlui May 20, 2019 21:07
@tseaver tseaver requested a review from crwilcox as a code owner May 20, 2019 21:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@jkwlui jkwlui mentioned this pull request May 20, 2019
Closed
8 tasks
@tseaver tseaver changed the title Storage: Add 'HMACKeyMetadata.{exists,reload}' methods. Storage: Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods. May 20, 2019
@tseaver
Copy link
Contributor Author

tseaver commented May 21, 2019

Rebased after merge of #8041 to the feature branch.

@tseaver
Copy link
Contributor Author

tseaver commented May 23, 2019

@jkwlui This PR is ready for review.

@tseaver
Copy link
Contributor Author

tseaver commented May 29, 2019

@jkwlui PTAL here, too.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 4, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Jun 5, 2019

@jkwlui The reCAPTCHA Enterprise failure is unrelated. PTAL.

@tseaver tseaver merged commit 970067b into googleapis:storage-add-hmac-key-support-feature Jun 19, 2019
@tseaver tseaver deleted the 7851-storage-hmac_key_metadata-exists-reload branch June 19, 2019 16:21
tseaver added a commit that referenced this pull request Jun 19, 2019
@tseaver
Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods. (#8045)
5b07516
@tseaver tseaver mentioned this pull request Jun 19, 2019
Merged
1 task
tseaver added a commit that referenced this pull request Jun 26, 2019
@tseaver
Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods. (#8045)
2914c04
tseaver added a commit that referenced this pull request Jul 2, 2019
@tseaver
Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods. (#8045)
0e25908
tseaver added a commit that referenced this pull request Jul 2, 2019
@tseaver
Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods. (#8045)
9934747
tseaver added a commit that referenced this pull request Jul 9, 2019
@tseaver
Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods. (#8045)
b46556f
tseaver added a commit that referenced this pull request Jul 9, 2019
@tseaver
Add 'HMACKeyMetadata.{exists,reload,update,delete}' API methods. (#8045)
5c8ee7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwlui jkwlui jkwlui approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @jkwlui @googlebot @yoshi-automation