build!: update typescript/gts (#243)

BREAKING CHANGE: typescript@3.7.x introduced backwards incompatibilities

.eslintrc.json

@@ -0,0 +1,3 @@
+{
+  "extends": "./node_modules/gts"
+}

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [8, 10, 12, 13]
+        node: [10, 12, 13]
     steps:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v1

.prettierignore

@@ -1,3 +1,5 @@
-node_modules/*
-samples/node_modules/*
-src/**/doc/*
+**/node_modules
+**/.coverage
+build/
+docs/
+protos/

.prettierrc.js

@@ -0,0 +1,17 @@
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+module.exports = {
+  ...require('gts/.prettierrc.json')
+}

package.json

@@ -13,15 +13,14 @@
     "check": "gts check && npm run license-check",
     "clean": "gts clean",
     "compile": "tsc -p .",
-    "fix": "gts fix && eslint --fix '**/*.js'",
+    "fix": "gts fix",
     "prepare": "npm run compile",
     "pretest": "npm run compile",
-    "posttest": "npm run check",
     "license-check": "jsgl --local .",
     "samples-test": "cd samples/ && npm link ../ && npm test && cd ../",
     "presystem-test": "npm run compile",
     "system-test": "mocha build/system-test",
-    "lint": "gts check && eslint '**/*.js'",
+    "lint": "gts check",
     "docs": "compodoc src/",
     "docs-test": "linkinator docs",
     "predocs-test": "npm run docs",
@@ -41,18 +40,14 @@
     "@types/mocha": "^7.0.0",
     "@types/node": "^10.0.9",
     "@types/node-forge": "^0.9.0",
+    "c8": "^7.0.0",
     "codecov": "^3.0.2",
-    "eslint": "^6.0.0",
-    "eslint-config-prettier": "^6.0.0",
-    "eslint-plugin-node": "^11.0.0",
-    "eslint-plugin-prettier": "^3.0.0",
-    "gts": "^1.0.0",
+    "gts": "^2.0.0-alpha.4",
     "js-green-licenses": "^1.0.0",
+    "linkinator": "^2.0.0",
     "mocha": "^7.0.0",
-    "c8": "^7.0.0",
     "prettier": "^1.15.3",
-    "typescript": "3.6.4",
-    "linkinator": "^2.0.0"
+    "typescript": "^3.8.3"
   },
   "engines": {
     "node": ">=10"

src/bin/gp12-pem.ts

@@ -14,13 +14,13 @@ const p12Path = argv[2];
 
 if (!p12Path) {
   console.error('Please specify a *.p12 file to convert.');
-  process.exit(1);
+  process.exitCode = 1;
 }
 
 gp12.getPem(p12Path, (err, pem) => {
   if (err) {
     console.log(err);
-    process.exit(1);
+    process.exitCode = 1;
   } else {
     console.log(pem);
   }

test/index.ts

@@ -39,27 +39,27 @@ describe('GoogleP12Pem', () => {
 
   it('should throw ENOENT on bad filename with no callback', done => {
     getPem('./badfilename.p12')
-      .then(pem => {
+      .then(() => {
         assert.fail('Returned pem when it should have been rejected');
       })
-      .catch(e => {
+      .catch(() => {
         done();
       });
   });
 
   it('should throw error on bad .p12 with no callback', done => {
     getPem(BADP12FILE)
-      .then(pem => {
+      .then(() => {
         assert.fail('Returned pem when it should have been rejected');
       })
-      .catch(e => {
+      .catch(() => {
         done();
       });
   });
 
   it('should return error on bad .p12 in callback', done => {
     assert.doesNotThrow(() => {
-      getPem(BADP12FILE, (err, pem) => {
+      getPem(BADP12FILE, err => {
         assert(err);
         if (err) {
           assert(err.message.indexOf('Too few bytes to read') > -1);
@@ -82,7 +82,7 @@ describe('GoogleP12Pem', () => {
       .then(result => {
         assert.strictEqual(expectedPem, result);
       })
-      .catch(e => {
+      .catch(() => {
         assert.fail('Error getting pem from promise.');
       });
   });

tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "./node_modules/gts/tsconfig-google.json",
   "compilerOptions": {
+    "lib": ["es2018", "dom"],
     "rootDir": ".",
     "outDir": "build"
   },