fix: emitting error event in fill

googleapis · Sep 11, 2024 · b3b645c · b3b645c
1 parent 992baaa
commit b3b645c
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -12,3 +12,4 @@ system-test/*key.json
 .DS_Store
 package-lock.json
 __pycache__
+.vscode
diff --git a/src/session-pool.ts b/src/session-pool.ts
@@ -815,12 +815,7 @@ export class SessionPool extends EventEmitter implements SessionPoolInterface {
     if (needed <= 0) {
       return;
     }
-
-    try {
-      await this._createSessions(needed);
-    } catch (e) {
-      this.emit('error', e);
-    }
+    await this._createSessions(needed);
   }
 
   /**

diff --git a/test/session-pool.ts b/test/session-pool.ts
@@ -515,6 +515,36 @@ describe('SessionPool', () => {
         process.listeners('unhandledRejection').push(originalRejection!);
       }
     });
+
+    it('should catch unhandled rejection errors', async () => {
+      const error = new Error('Unexpected error') as grpc.ServiceError;
+
+      sandbox.restore();
+      sandbox.stub(sessionPool, '_fill').callsFake(async () => {
+        throw error;
+      });
+
+      const originalRejection = process.listeners('unhandledRejection').pop();
+      if (originalRejection) {
+        process.removeListener('unhandledRejection', originalRejection!);
+      }
+
+      process.once('unhandledRejection', err => {
+        assert.ifError(err);
+      });
+
+      const errorListener = sandbox.stub();
+      sessionPool.on('error', errorListener);
+
+      await sessionPool.open();
+
+      assert.strictEqual(errorListener.calledOnce, true);
+      assert.strictEqual(errorListener.firstCall.args[0], error);
+
+      if (originalRejection) {
+        process.listeners('unhandledRejection').push(originalRejection!);
+      }
+    });
   });
 
   describe('release', () => {