Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

observability: use manual tracing instead of auto-traceWrapping until opentelemetry-instrumentation-spanner is ported #2114

Open
2 tasks
odeke-em opened this issue Sep 17, 2024 · 0 comments · May be fixed by #2118
Open
2 tasks

observability: use manual tracing instead of auto-traceWrapping until opentelemetry-instrumentation-spanner is ported #2114

odeke-em opened this issue Sep 17, 2024 · 0 comments · May be fixed by #2118
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@odeke-em
Copy link
Contributor

This issue serves as a decision marker and record for our method of attack to get observability in for this package. I implemented
2 kinds of tracing to ensure the team had a buffet of options:

Internally at Google it was discussed and resolved with @surbhigarg92 representing us when tabled with the OpenTelemetry team at Google that:

  • traceWrap was well received but we should send that instrumentation to be hosted at opentelemetry-js-contrib
  • manually instrument the libraries currently

One thing to note is that we shall need to add feature guards that will ensure that customers don't doubly import the future opentelemetry-instrumentation-spanner and then also with the manual spans.
@odeke-em odeke-em added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 17, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Sep 17, 2024
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 17, 2024
@odeke-em
observability: trace BatchTransaction and Table
edc3804 
This change is part of a series of changes to add
OpenTelemetry traces, focused on BatchTransaction and Table.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 17, 2024
@odeke-em
observability: trace BatchTransaction and Table
e74c73e 
This change is part of a series of changes to add
OpenTelemetry traces, focused on BatchTransaction and Table.

While here, made the tests for sessionPool spans much more
precise to avoid flakes.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
@odeke-em odeke-em mentioned this issue Sep 17, 2024
Merged
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 19, 2024
@odeke-em
observability: trace BatchTransaction and Table
ea6d7f2 
This change is part of a series of changes to add
OpenTelemetry traces, focused on BatchTransaction and Table.

While here, made the tests for sessionPool spans much more
precise to avoid flakes.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 19, 2024
@odeke-em
feat(observability): trace BatchTransaction and Table
38708a8 
This change is part of a series of changes to add
OpenTelemetry traces, focused on BatchTransaction and Table.

While here, made the tests for sessionPool spans much more
precise to avoid flakes.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 20, 2024
@odeke-em
feat(observability): trace BatchTransaction and Table
d5b7756 
This change is part of a series of changes to add
OpenTelemetry traces, focused on BatchTransaction and Table.

While here, made the tests for sessionPool spans much more
precise to avoid flakes.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 20, 2024
@odeke-em
feat(observability): trace BatchTransaction and Table
db71593 
This change is part of a series of changes to add
OpenTelemetry traces, focused on BatchTransaction and Table.

While here, made the tests for sessionPool spans much more
precise to avoid flakes.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 20, 2024
@odeke-em
feat(observability): trace BatchTransaction and Table
7357d35 
This change is part of a series of changes to add
OpenTelemetry traces, focused on BatchTransaction and Table.

While here, made the tests for sessionPool spans much more
precise to avoid flakes.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 20, 2024
@odeke-em
feat(observability): trace BatchTransaction and Table
23032f9 
This change is part of a series of changes to add
OpenTelemetry traces, focused on BatchTransaction and Table.

While here, made the tests for sessionPool spans much more
precise to avoid flakes.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 20, 2024
@odeke-em
feat(observability): trace BatchTransaction and Table
6adf870 
This change is part of a series of changes to add
OpenTelemetry traces, focused on BatchTransaction and Table.

While here, made the tests for sessionPool spans much more
precise to avoid flakes.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 20, 2024
@odeke-em
feat: (observability) add spans for BatchTransaction and Table (#2115)
d51aae9 
This change is part of a series of changes to add
OpenTelemetry traces, focused on BatchTransaction and Table.

While here, made the tests for sessionPool spans much more precise to avoid flakes.

Updates #2079
Built from PR #2087
Updates #2114
@release-please release-please bot linked a pull request Sep 20, 2024 that will close this issue
Open
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 20, 2024
@odeke-em
feat(observability): trace Database methods
332c1ae 
Adds trace spans for Database methods, as well as tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
@odeke-em odeke-em mentioned this issue Sep 20, 2024
Merged
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 20, 2024
@odeke-em
feat(observability): trace Database methods
87ebbf7 
Adds trace spans for Database methods, as well as tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 20, 2024
@odeke-em
feat(observability): trace Database methods
c6e430f 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 21, 2024
@odeke-em
feat(observability): add tracing spans to Session
933949f 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
@odeke-em odeke-em mentioned this issue Sep 21, 2024
Open
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
b8d0789 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
@odeke-em odeke-em mentioned this issue Sep 22, 2024
Open
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
eec1cb0 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
df962ac 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
5020567 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
27a2d25 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
f2e18a9 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
396e5c9 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
15a1eb4 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
09d2d31 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
4f41e6b 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
19bca97 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
ead94f4 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
9a48feb 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
a4e56f3 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
a477344 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
e0c1dd1 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
0b9aedd 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): trace Transaction
b4217d8 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 22, 2024
@odeke-em
feat(observability): add tracing spans to Session
1942877 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 23, 2024
@odeke-em
feat(observability): add tracing spans to Session
ec48f2c 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 23, 2024
@odeke-em
feat(observability): trace Transaction
afa5873 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 23, 2024
@odeke-em
feat(observability): add tracing spans to Session
8de217a 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 23, 2024
@odeke-em
feat(observability): add tracing spans to Session
909108d 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 23, 2024
@odeke-em
feat(observability): add tracing spans to Session
d670cd6 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 23, 2024
@odeke-em
feat(observability): trace Database methods
1fd16b4 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 23, 2024
@odeke-em
feat(observability): trace Database methods
65ca9f3 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 23, 2024
@odeke-em
feat(observability): trace Database methods
0a205fc 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 30, 2024
@odeke-em
feat(observability): trace Database methods
a34c7b1 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 30, 2024
@odeke-em
feat(observability): add tracing spans to Session
62a9ba8 
This change adds tracing spans to Session for methods:
* create
* getMetadata
* keepAlive

and corresponding tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 30, 2024
@odeke-em
feat(observability): trace Transaction
4fc8fe7 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Sep 30, 2024
@odeke-em
feat(observability): trace Database methods
eeb628b 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 30, 2024
@odeke-em
feat(observability): trace Database methods (#2119)
1f06871 
Adds trace spans for Database methods, as well as tests
for methods:

* getSession
* getSnapshot
* run
* runStream
* runTransaction

tracing of other methods shall come in follow-up PRs.

Updates #2079
Built from PR #2087
Updates #2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Oct 1, 2024
@odeke-em
feat(observability): trace Transaction
d8fe92b 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Oct 1, 2024
@odeke-em
feat(observability): trace Transaction
838225e 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Oct 1, 2024
@odeke-em
feat(observability): trace Transaction
9fa7878 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Oct 3, 2024
@odeke-em
feat(observability): trace Transaction
310bf59 
This change adds observability tracing for
Transaction along with tests.

Alsoo while here, added SessionPool.createSessions span.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Oct 3, 2024
@odeke-em
feat(observability): trace Transaction
ac8b6e0 
This change adds observability tracing for
Transaction along with tests.

Alsoo while here, added SessionPool.createSessions span.

Updates googleapis#2079
Built from PR googleapis#2087
Updates googleapis#2114
odeke-em added a commit to odeke-em/nodejs-spanner that referenced this issue Oct 4, 2024
@odeke-em
feat(observability): trace Transaction
1050d50 
This change adds observability tracing for
Transaction along with tests.

Updates googleapis#2079
Updates googleapis#2114
Requires PR googleapis#2145.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 7.15.0 googleapis/nodejs-spanner
1 participant
@odeke-em