Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix tests failing because of Editions #2142

Merged
merged 2 commits into from
Oct 3, 2024
Merged

test: fix tests failing because of Editions #2142

merged 2 commits into from
Oct 3, 2024

Conversation

rahul2393
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rahul2393 rahul2393 requested review from a team as code owners October 3, 2024 06:56
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Oct 3, 2024
@alkatrivedi alkatrivedi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 3, 2024
@rahul2393 rahul2393 merged commit 85a9b0f into main Oct 3, 2024
19 checks passed
@rahul2393 rahul2393 deleted the fix_tests branch October 3, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkatrivedi alkatrivedi alkatrivedi approved these changes

@surbhigarg92 surbhigarg92 Awaiting requested review from surbhigarg92

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahul2393 @alkatrivedi @yoshi-kokoro