Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest version of grpcio-tools #94

Closed
parthea opened this issue Mar 17, 2022 · 3 comments · Fixed by #95
Closed

Update to the latest version of grpcio-tools #94

parthea opened this issue Mar 17, 2022 · 3 comments · Fixed by #95
Assignees
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@parthea
Copy link
Contributor

parthea commented Mar 17, 2022

PR #87 regenerated pb2 files using the latest version of grpcio-tools. There is an issue reported in #91 where the changes result in AttributeError: 'NoneType' object has no attribute 'message_types_by_name'. I was able to reproduce the issue in a virtual environment using the steps in #91. The issue is no longer present when I pin grpcio-tools<1.44.0 and regenerate protos using the previous version of grpcio-tools.

I've opened #93 to pin the version of grpcio-tools so development can continue in this repo.

@lidizheng
Copy link

A similar issue is reported at protocolbuffers/protobuf#8803.

@lidizheng
Copy link

Can you try to bump the version of ProtoBuf and try again? For each gRPC release, we will try to use the ProtoBuf latest release at given time.

@parthea
Copy link
Contributor Author

parthea commented Mar 17, 2022

Thanks @lidizheng ! We'll bump the minimum protobuf to 3.15.0 here https://github.com/googleapis/python-api-common-protos/blob/main/setup.py#L25 .

Version 3.15.0 doesn't have the error. In addition, the issue reported in #91 was using a pre-release version protobuf 4.0.0rc2 which is yanked. I tested the latest pre-release for protobuf version protobuf-3.20.0rc2 and couldn't reproduce the issue.

@parthea parthea self-assigned this Mar 17, 2022
@parthea parthea added the type: process A process-related concern. May include testing, release, or the like. label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
2 participants