-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: regenerate pb2 files using the latest version of grpcio-tools #95
Conversation
972027a
to
9aef768
Compare
I'll check to make sure the Kokoro test fails before adding the commit to require |
…ub.com/googleapis/python-api-common-protos into use-the-latest-version-of-grpcio-tools
The |
I tested unit-3.6/3.7/3.8/3.9 and only unit-3.9 failed.
|
noxfile.py
Outdated
@@ -72,6 +72,7 @@ def default(session): | |||
) | |||
|
|||
|
|||
@nox.session(python=["3.6", "3.7", "3.8", "3.9", "3.10"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package has no tests, so it instead runs the unit and system tests of client libraries that take a dependency instead.
This session not meant to be directly run as a session. If you look below at test
, it calls unit()
and system()
.
noxfile.py
Outdated
@@ -55,7 +55,7 @@ def default(session): | |||
|
|||
# Install googleapis-api-common-protos | |||
# This *must* be the last install command to get the package from source. | |||
session.install("e", "..", "-c", constraints_path) | |||
session.install("e", ".", "-c", constraints_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the changes in noxfile.py
, I believe the tests are installing googleapis-common-protos
from PyPI instead of source.
Note in the log python -m pip install -e .
comes after cd python-texttospeech
, so .
is python-texttospeech
, ..
is python-api-common-protos
.
nox > Session test-3.9(pubsub) was successful.
nox > Running session test-3.9(texttospeech)
nox > Creating virtual environment (virtualenv) using python3.9 in .nox/test-3-9-texttospeech
nox > git -C python-texttospeech pull
Already up to date.
nox > cd python-texttospeech
nox > python -m pip install asyncmock pytest-asyncio
nox > python -m pip install mock pytest pytest-cov
nox > python -m pip install -e .
nox > python -m pip install e . -c /tmpfs/src/github/python-api-common-protos/testing/constraints-3.9.txt
nox > py.test --quiet --cov=google/cloud --cov=tests/unit --cov-append --cov-config=.coveragerc --cov-report= --cov-fail-under=0 tests/unit
Fixes #91 🦕
Fixes #94 🦕
BEGIN_COMMIT_OVERRIDE
fix: regenerate pb2 files using the latest version of grpcio-tools
fix(deps): require protobuf >=1.15.0
END_COMMIT_OVERRIDE