-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add cross_sync #999
Open
daniel-sanche
wants to merge
260
commits into
main
Choose a base branch
from
cross_sync2_pr1_architecture
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-sanche
force-pushed
the
cross_sync2_pr1_architecture
branch
from
September 6, 2024 21:54
d48b8ae
to
a3cb9a6
Compare
daniel-sanche
force-pushed
the
cross_sync2_pr1_architecture
branch
from
September 6, 2024 22:41
d44918d
to
11ab1d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigtable
Issues related to the googleapis/python-bigtable API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1/x for adding the sync surface for the new data client
This class adds ast transformers for converting existing async classes into sync copies.
The conversion works through the following phases:
generate.py
is called with a path, and finds all Python files in all subdirectoriesCrossSyncClassDecoratorHandler
is called on each file, looking for any classes decorated with@CrossSync.export_sync
CrossSyncMethodDecoratorHandler
to look for any methods annotated with CrossSync decorators (CrossSunc.convert
,CrossSync.drop_method
,CrossSync.pytest
, etc).RmAioFunctions
to strip out any asyncio keywords annotated withCrossSync.rmaio()
SymbolReplacer
to replaceCrossSync
withCrossSync._Sync_Impl
in the codebase, and other user-specified symbol transformatioonsNext PR will add annotations to existing code to guide transformations
TODO:
add CrossSync Readme