Skip to content

Commit

Permalink
fix(deps): add explicit ranges for 'google-api-core' and 'google-auth' (
Browse files Browse the repository at this point in the history
#530)

Transitive dependency resolution breaks unit tests under Python 3.6
following PR #520.

Pin minima for those ranges explicitly when testing under Python 3.6.

Closes #529.
  • Loading branch information
tseaver authored Aug 5, 2021
1 parent ef41bc1 commit 310f207
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
6 changes: 4 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@
# 'Development Status :: 5 - Production/Stable'
release_status = "Development Status :: 5 - Production/Stable"
dependencies = [
"google-auth >= 1.24.0, < 2.0dev; python_version<'3.0'",
"google-auth >= 1.24.0, < 3.0dev; python_version>='3.6'",
"google-auth >= 1.25.0, < 2.0dev; python_version<'3.0'",
"google-auth >= 1.25.0, < 3.0dev; python_version>='3.6'",
"google-api-core >= 1.29.0, < 2.0dev; python_version<'3.0'",
"google-api-core >= 1.29.0, < 3.0dev; python_version>='3.6'",
"google-cloud-core >= 1.6.0, < 2.0dev; python_version<'3.0'",
"google-cloud-core >= 1.6.0, < 3.0dev; python_version>='3.6'",
"google-resumable-media >= 1.3.0, < 2.0dev; python_version<'3.0'",
Expand Down
3 changes: 2 additions & 1 deletion testing/constraints-3.6.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
#
# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev",
# Then this file should have foo==1.14.0
google-auth==1.24.0
google-auth==1.25.0
google-api-core==1.29.0
google-cloud-core==1.6.0
google-resumable-media==1.3.0
requests==2.18.0

0 comments on commit 310f207

Please sign in to comment.