Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update retention policy sys tests to avoid caching changes wait #1068

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Jun 28, 2023

Unflake the bucket retention policy tests by splitting into
(1) test deleting objects in a newly created bucket with retention period (avoids extended wait from caching changes)
(2) test updating bucket retention policy

Fixes #1065

@cojenco cojenco requested review from a team as code owners June 28, 2023 19:08
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Jun 28, 2023
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2023
@cojenco cojenco merged commit cc191b0 into googleapis:main Jun 29, 2023
@cojenco cojenco deleted the fix-systest branch November 16, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests.system.test_bucket: test_bucket_w_retention_period failed
2 participants