Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: self-upload files for Unicode system test #296

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

andrewsg
Copy link
Contributor

TestUnicode system tests are failing because a public repository of files was deleted. Rather than replace those public files, this PR self-uploads the files as per other tests.

While using a public bucket for this test had some advantages in test fidelity, the brittleness of relying on external static files is a significant problem and this is a compromise solution.

@andrewsg andrewsg requested a review from frankyn October 15, 2020 19:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
@andrewsg andrewsg merged commit 6f865d9 into master Oct 15, 2020
@andrewsg andrewsg deleted the fix-unicode-system-test branch October 16, 2020 19:22
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants