Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Amend default retry behavior for bucket operations on client #358

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Jan 7, 2021

Fixes: #357

The bug exposed a hole in our testing of the new retry defaults, so this PR also adds some simple tests to verify defaults are correct. It doesn't try to comprehensively validate all defaults throughout the library, but the existence of this bug suggests we might want to audit those to make sure.

@andrewsg andrewsg requested review from frankyn and a team January 7, 2021 20:25
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jan 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2021
google/cloud/storage/client.py Show resolved Hide resolved
tests/unit/test_client.py Outdated Show resolved Hide resolved
@andrewsg
Copy link
Contributor Author

@tseaver PTAL

@andrewsg andrewsg merged commit b91e57d into master Jan 21, 2021
@andrewsg andrewsg deleted the get_bucket_retry_default branch January 21, 2021 23:41
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…ogleapis#358)

* fix: Amend default retry behavior for bucket operations on client

* Amend default for blob/bucket get and exist methods

* fix tests for new behavior
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…ogleapis#358)

* fix: Amend default retry behavior for bucket operations on client

* Amend default for blob/bucket get and exist methods

* fix tests for new behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Gateway timeout
4 participants