-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pin six as a required dependency #589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Issues related to the googleapis/python-storage API.
label
Sep 16, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 16, 2021
busunkim96
approved these changes
Sep 16, 2021
cojenco
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pinning these!
tseaver
reviewed
Sep 16, 2021
@@ -37,7 +37,9 @@ | |||
"google-resumable-media >= 1.3.0, < 2.0dev; python_version<'3.0'", | |||
"google-resumable-media >= 1.3.0, < 3.0dev; python_version>='3.6'", | |||
"requests >= 2.18.0, < 3.0.0dev", | |||
"protobuf < 3.18.0; python_version<'3.0'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be adding an un-pinned protobuf
for Python 3.x (to avoid future transitive dep failures):
Suggested change
"protobuf < 3.18.0; python_version<'3.0'", | |
"protobuf < 3.18.0; python_version<'3.0'", | |
"protobuf; python_version>='3.6'", |
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* fix: pin six as a required dependency * chore: pin protobuf for older Python 2.7
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* fix: pin six as a required dependency * chore: pin protobuf for older Python 2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/python-storage API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
six
used to be a transitive dependency throughprotobuf
, but now it is not specified in any of the other dependencies thus the tests are failing, and any other installations to the current latest version would fail.protobuf
also dropped support for Python 2.7 as of 3.18.0. Pinning it for 2.7.Fixes #588 🦕