docs(storage): add documentation for blob and bucket name property #89

HemangChothani · 2020-03-24T10:14:12Z

Fixes #82

googlebot · 2020-03-24T10:14:15Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

HemangChothani · 2020-03-24T10:17:05Z

@googlebot I signed it!

frankyn

Thanks, I have two nits.

frankyn · 2020-03-24T14:30:42Z

google/cloud/storage/blob.py

+        """
+        return self._name
+
+    @name.setter


Recommend removing setter.

@frankyn If i remove setter then it throws an error like AttributeError: can't set attribute

Is this why you recommended only adding pydocs instead? If so, then let's do that instead.

@frankyn Yes , that's why i recommend doc static doc string. i will update the PR. Thanks.

frankyn · 2020-03-24T14:30:52Z

google/cloud/storage/bucket.py

+        return self._name
+
+    @name.setter
+    def name(self, value):


Here as well

googlebot · 2020-03-30T05:35:10Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

frankyn · 2020-04-01T19:16:07Z

google/cloud/storage/bucket.py

        name = _validate_name(name)
        super(Bucket, self).__init__(name=name)
        self._client = client
        self._acl = BucketACL(self)
        self._default_object_acl = DefaultObjectACL(self)
        self._label_removals = set()
        self._user_project = user_project
+        self._name = name


is this still necessary?

…into storage_issue_82

gcf-merge-on-green · 2020-04-16T03:36:09Z

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

gcf-merge-on-green · 2020-04-16T03:38:03Z

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

gcf-merge-on-green · 2020-04-16T06:36:08Z

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

…into storage_issue_82

…storage into storage_issue_82

…into storage_issue_82

…oogleapis#89) Fixes googleapis#82

HemangChothani requested review from tseaver, crwilcox and frankyn March 24, 2020 10:14

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 24, 2020

frankyn requested changes Mar 24, 2020

View reviewed changes

docs(storage): add documentation for blob and bucket name property

4fe3494

MaxxleLLC force-pushed the storage_issue_82 branch from fa16c0f to 4fe3494 Compare March 30, 2020 05:35

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 30, 2020

docs(storage): add pydocs for property documentation

0de7854

frankyn reviewed Apr 1, 2020

View reviewed changes

HemangChothani added 2 commits April 2, 2020 10:49

docs(storage): remove ununsed variable

d5c8a32

Merge branch 'master' of https://github.com/googleapis/python-storage …

b02179c

…into storage_issue_82

frankyn approved these changes Apr 2, 2020

View reviewed changes

Merge branch 'master' into storage_issue_82

ee7de2e

frankyn added the automerge Merge the pull request once unit tests and other checks pass. label Apr 16, 2020

HemangChothani added 3 commits April 16, 2020 12:22

Merge branch 'master' of https://github.com/googleapis/python-storage …

4488669

…into storage_issue_82

Merge branch 'storage_issue_82' of https://github.com/q-logic/python-…

707aa95

…storage into storage_issue_82

Merge branch 'master' of https://github.com/googleapis/python-storage …

5e9b22b

…into storage_issue_82

HemangChothani added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Apr 16, 2020

gcf-merge-on-green bot merged commit cecc7ac into googleapis:master Apr 16, 2020

cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021

docs(storage): add documentation for blob and bucket name property (g…

12ba11b

…oogleapis#89) Fixes googleapis#82

cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021

docs(storage): add documentation for blob and bucket name property (g…

540c119

…oogleapis#89) Fixes googleapis#82

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(storage): add documentation for blob and bucket name property #89

docs(storage): add documentation for blob and bucket name property #89

HemangChothani commented Mar 24, 2020

googlebot commented Mar 24, 2020

HemangChothani commented Mar 24, 2020

frankyn left a comment

frankyn Mar 24, 2020

HemangChothani Mar 24, 2020

frankyn Mar 31, 2020

HemangChothani Apr 1, 2020

frankyn Mar 24, 2020

googlebot commented Mar 30, 2020

frankyn Apr 1, 2020

gcf-merge-on-green bot commented Apr 16, 2020

gcf-merge-on-green bot commented Apr 16, 2020

gcf-merge-on-green bot commented Apr 16, 2020

docs(storage): add documentation for blob and bucket name property #89

docs(storage): add documentation for blob and bucket name property #89

Conversation

HemangChothani commented Mar 24, 2020

googlebot commented Mar 24, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

HemangChothani commented Mar 24, 2020

frankyn left a comment

Choose a reason for hiding this comment

frankyn Mar 24, 2020

Choose a reason for hiding this comment

HemangChothani Mar 24, 2020

Choose a reason for hiding this comment

frankyn Mar 31, 2020

Choose a reason for hiding this comment

HemangChothani Apr 1, 2020

Choose a reason for hiding this comment

frankyn Mar 24, 2020

Choose a reason for hiding this comment

googlebot commented Mar 30, 2020

frankyn Apr 1, 2020

Choose a reason for hiding this comment

gcf-merge-on-green bot commented Apr 16, 2020

gcf-merge-on-green bot commented Apr 16, 2020

gcf-merge-on-green bot commented Apr 16, 2020