-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add group name to branch name #1924
base: main
Are you sure you want to change the base?
fix: add group name to branch name #1924
Conversation
… more than 1 pull request to merge
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I change this file to add and run the Merge plugin afterwards, because that way the if condition was much simpler to read.
I'm expanding the if condition to also check for the number of new pull requests, so that it won't attempt a merge if there aren't multiple PRs that should be merged together. While updating the code for the linked-versions project we encountered a problem where one remaining PR was renamed because of the merge attempt of 1 PR.
feat: add group-branch-name-pattern property
@chingor13 Could you take a look at this? |
Heya 👋
I'm intentionally opening this PR before being done with all the tests/docs because I'd like your feedback on this approach.
Fixes #1923 🦕