Skip to content

Commit

Permalink
fix: Add Geo common protos to Bazel test dependencies. (#2033)
Browse files Browse the repository at this point in the history
The generated unit tests for google/maps/places is not compilable, this is due to a Geo common proto is not added to Bazel test dependencies. See cl/567435528 and yaqs/8970072045605879808 for details.

In long term, the Bazel Java test should be replaced with Maven/Gradle tests, so all the dependencies are managed through the gapic-generator-java jar instead of Bazel. This should be done as part of the Hermetic build project, cc: @JoeWang1127
  • Loading branch information
blakeli0 committed Sep 25, 2023
1 parent 97bf9ed commit 625ecc5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions rules_java_gapic/java_gapic.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ def java_gapic_library(
# Test deps.
actual_test_deps = [
"@com_google_googleapis//google/type:type_java_proto", # Commonly used.
"@com_google_googleapis//google/geo/type:viewport_java_proto", # Used by Geo.
"@com_google_api_gax_java//gax:gax_testlib",
"@com_google_code_gson_gson//jar",
"@junit_junit//jar",
Expand Down

0 comments on commit 625ecc5

Please sign in to comment.