-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up hermetic build script and test #1943
Conversation
This reverts commit 3d612f8.
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-java@v3 | ||
with: | ||
java-version: ${{ matrix.java }} | ||
distribution: temurin | ||
cache: maven | ||
- uses: kanga333/variable-mapper@3681b75f5c6c00162721168fb91ab74925eaebcb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a personal project that has very few usage based on the Github stars, it looks risky to me and I'm not sure we want to use it. Is there any alternatives?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a personal project that has very few usage based on the Github stars, it looks risky to me and I'm not sure we want to use it.
Makes sense. I'll do more research then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matrix:
sys: [ {os: ubuntu-22.04, arch: linux-x86_64}, {os: macos-12, arch: osx-x86_64} ]
...
${{ matrix.sys.os }} and ${{ matrix.sys.arch }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@burkedavison thanks for the help.
However, Github complains that: Matrix options must only contain primitive values
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! |
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! |
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What made the test execution so much faster? The |
I think it speeds up by not checking out HEAD of googleapis-gen ( As for |
Builds on #1916.
Allow running on OSX in addition to Linux.
Test execution improvement from 2m45s to 11s.