Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate showcase without postprocessing #1946

Closed
wants to merge 70 commits into from
Closed

feat: generate showcase without postprocessing #1946

wants to merge 70 commits into from

Conversation

diegomarquezp
Copy link
Contributor

Modifies the logic of #1916 to support generation of showcase

NOTES

  • Referencing an external repository as the source of the protos when building showcase makes the proto folder to contain a path that includes the external reference. Googleapis-based generated libraries do not contain this difference (example) but instead contain the proto_path (i.e. path from repository root to proto location).
    • To fix this, I added an extra postprocessing step in the current showcase generation
    • I also tried modifying the bazel BUILD file to copy the protos into showcase but it produced a similar result - a path like proto/bazel-out/.../schema/....

PENDING

  • use current snapshot of gapic-generator-java to generate showcase (currently uses a published version)

@JoeWang1127
feat: add
53abd0e
@JoeWang1127
generate gapic and proto folder
434cbfc
@JoeWang1127
refactor utilities
5825bcc
@JoeWang1127
add an action to verify
c39cbea
@JoeWang1127
checkout googleapis-gen
10a1c6d
@JoeWang1127
setup repo name
cca6770
@JoeWang1127
add commit hash of googleapis-gen
89bbedc
@JoeWang1127
change secret
3e85e33
@JoeWang1127
change token
fdf9260
@JoeWang1127
change to git clone
f3b60a6
@JoeWang1127
change user name
1b4746d
@JoeWang1127
add input list
2856709
@JoeWang1127
include resources folder in main
81cbdc2
@JoeWang1127
remove grpc version in *ServiceGrpc.java
d733c5a
@JoeWang1127
change destination path
92660ff
@JoeWang1127
compare generation result with googleapis-gen
07f3ea6
@JoeWang1127
fix type in diff command
49542f7
@JoeWang1127
checkout repo using checkout action
d7b3752
@JoeWang1127
checkout repos as nested repo
0c8aa78
@JoeWang1127
sparse checkout googleapis
3d612f8
@JoeWang1127
Revert "sparse checkout googleapis"
280a571 
This reverts commit 3d612f8.
@JoeWang1127
change library
d375848
@JoeWang1127
change step name
734e1eb
@JoeWang1127
add a readme
9a5a7cd
@JoeWang1127
make grpc version optional
35ad197
@JoeWang1127
make protobuf version optional
8477b74
@JoeWang1127
checkout master branch, rather than a commit hash
5eb0223
@JoeWang1127
allow snapshot version of generator
b12f99e
@JoeWang1127
download snapshot of generator parent pom
e893df3
@JoeWang1127
update README
a7d8a55
diegomarquezp and others added 26 commits August 21, 2023 17:34
@diegomarquezp
chore: add diff check for showcase IT
3b6dfeb
@JoeWang1127
do not delete google/
64ee89e
@JoeWang1127
Merge branch 'main' into feat/generate-aiplatform-without-postprocessing
56e418a
@diegomarquezp
chore: change file mod in protos
5fd6aac
@diegomarquezp
chore: fix diff comparison
5a94a72
@diegomarquezp
Merge remote-tracking branch 'origin/feat/generate-aiplatform-without…
06d0351 
…-postprocessing' into feat/generate-showcase-without-postprocessing
@diegomarquezp
chore: remove unwanted binary
ad59c57
@JoeWang1127
get protobuf version from WORKSPACE
a056ae1
@JoeWang1127
add instructions on download google/ from googleapis
7ef8278
@JoeWang1127
add comments
4f0ef4a
@diegomarquezp
chore: final adjustments for showcase testing
7adf70d
@diegomarquezp
chore: allow workflow dispatch on workflow
0d305d2
@diegomarquezp
chore: correct yaml definition
3d62a2b
@diegomarquezp
chore: correct yaml definition ii
5b59674
@diegomarquezp
Merge remote-tracking branch 'origin/feat/generate-aiplatform-without…
3cf0df2 
…-postprocessing' into feat/generate-showcase-without-postprocessing
@diegomarquezp
chore: fix util import
f8816a4
@JoeWang1127
update description of destination_path
5805e84
@diegomarquezp
chore: correct version parsing
6aa42fb
@diegomarquezp
chore: correct showcase version
20554ee
@diegomarquezp
chore: try java 11
aa12966
@JoeWang1127
update comments
880c27b
@diegomarquezp
chore: infer grpc_version from parent pom
1e6269b
@JoeWang1127
download dependencies using curl
a5fe171
@JoeWang1127
increase download time
f6c5784
@JoeWang1127
remove comment
5d16f16
@diegomarquezp
Merge branch 'feat/generate-aiplatform-without-postprocessing' into f…
3275765 
…eat/generate-showcase-without-postprocessing
@diegomarquezp diegomarquezp requested a review from a team as a code owner August 28, 2023 15:18
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 28, 2023
@diegomarquezp diegomarquezp changed the title Feat/generate showcase without postprocessing feat: generate showcase without postprocessing Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegomarquezp @JoeWang1127