Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "google-cloud-aiplatform[prediction]" as custom requirement for Kokoro script #260

Closed
dandhlee opened this issue Oct 10, 2022 · 2 comments · Fixed by #261
Closed

Add "google-cloud-aiplatform[prediction]" as custom requirement for Kokoro script #260

dandhlee opened this issue Oct 10, 2022 · 2 comments · Fixed by #261
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@dandhlee
Copy link
Collaborator

There is a new library in python-aiplatform that requires a special install. Filing the issue to keep track of this.

@dandhlee dandhlee added type: process A process-related concern. May include testing, release, or the like. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Oct 10, 2022
@dandhlee dandhlee self-assigned this Oct 10, 2022
@tbpg
Copy link
Contributor

tbpg commented Oct 11, 2022

What exactly does this mean? Sounds like the general docs plugin needs to install something to be able to handle a particular library? Feels like the library should have dependencies set up so that isn't necessary? I'm probably misunderstanding.

@dandhlee
Copy link
Collaborator Author

The library in question does have a specific handler for this (https://github.com/googleapis/python-aiplatform/blob/12be04ccc63926a25afef61aae9747fdb6043030/noxfile.py#L312). I need to also add it in the script when generating the docs for that particular part of the library, namely for prediction portion, in https://github.com/googleapis/sphinx-docfx-yaml/blob/main/.kokoro/requirements.in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants