Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependencies #261

Merged
merged 4 commits into from
Oct 31, 2022
Merged

chore(deps): update dependencies #261

merged 4 commits into from
Oct 31, 2022

Conversation

dandhlee
Copy link
Collaborator

Adding specific installation for aiplatform[prediction]. Also making the requirements.in file look nicer :)

Fixes #260.

  • Tests pass
  • Appropriate changes to README are included in PR

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Oct 31, 2022
@dandhlee
Copy link
Collaborator Author

dandhlee commented Oct 31, 2022

Confirmed prediction is picked up in Kokoro test from the update based on this PR:

writing output... [ 98%] prediction_v1/types
writing output... [100%] prediction_v1beta1/types

this would not show if prediction library is not installed as Sphinx would not be able to pick up on it.

@dandhlee dandhlee marked this pull request as ready for review October 31, 2022 05:38
@dandhlee dandhlee requested review from a team as code owners October 31, 2022 05:38
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't the library itself install these dependencies?

@dandhlee
Copy link
Collaborator Author

dandhlee commented Oct 31, 2022

I have learned what they are! They are called library extras, when they're installed as like aiplatform[prediction] with extras being inside []. They are optional extras that folks can install.

Dustin filed a feature request before: pypa/setuptools#1503, but tl;dr is that with current state of python packaging, it is not possible to ask for users to install all or some extras as default when you simply install aiplatform for example. It must be explicitly done :/

@tbpg
Copy link
Contributor

tbpg commented Oct 31, 2022

I guess I'm wondering if the aiplatform[prediction] library can install its necessary dependencies to generate documentation? Rather than having to do it in a generic doc generator library?

In other words, if this was a third-party library, it wouldn't make sense for it to require aiplatform[prediction].

@dandhlee
Copy link
Collaborator Author

Ah, they can! I'm just adding support for this in the mega generator in case I have to regenerate all the docs and didn't want to miss out on prediction or other smaller bits as well.

@tbpg
Copy link
Contributor

tbpg commented Oct 31, 2022

Will you add a comment explaining that? Perhaps that regeneration script could install those dependencies separately?

@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2022
@dandhlee
Copy link
Collaborator Author

Done! Please take a look again.

@dandhlee dandhlee requested a review from tbpg October 31, 2022 19:40
@dandhlee dandhlee merged commit b66f42b into main Oct 31, 2022
@dandhlee dandhlee deleted the add_prediction_library branch October 31, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "google-cloud-aiplatform[prediction]" as custom requirement for Kokoro script
2 participants