Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove use of googleapis-discovery #1280

Merged
merged 5 commits into from
Apr 1, 2022
Merged

chore: remove use of googleapis-discovery #1280

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72acc6a
chore: remove use of googleapis-discovery
bshaffer Nov 10, 2021
2abce50
remove constant and method for googleapis-discovery
bshaffer Nov 10, 2021
4c6fadc
Merge branch 'master' into bshaffer-patch-1
bshaffer Dec 6, 2021
287f10e
Merge branch 'master' into bshaffer-patch-1
parthea Mar 17, 2022
22ddb7c
Merge branch 'master' into bshaffer-patch-1
parthea Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions synthtool/gcp/gapic_bazel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@

GOOGLEAPIS_URL: str = git.make_repo_clone_url("googleapis/googleapis")
GOOGLEAPIS_PRIVATE_URL: str = git.make_repo_clone_url("googleapis/googleapis-private")
GOOGLEAPIS_DISCOVERY_URL: str = git.make_repo_clone_url(
"googleapis/googleapis-discovery"
)
DISCOVERY_ARTIFACT_MANAGER_URL: str = git.make_repo_clone_url(
"googleapis/discovery-artifact-manager"
)
Expand Down Expand Up @@ -94,9 +91,6 @@ def _generate_code(
if discogapic:
api_definitions_repo = self._clone_discovery_artifact_manager()
api_definitions_repo_name = "discovery-artifact-manager"
elif diregapic:
api_definitions_repo = self._clone_googleapis_discovery()
api_definitions_repo_name = "googleapis-discovery"
elif private:
api_definitions_repo = self._clone_googleapis_private()
api_definitions_repo_name = "googleapis_private"
Expand Down Expand Up @@ -296,22 +290,6 @@ def _clone_googleapis_private(self):

return self._googleapis_private

def _clone_googleapis_discovery(self):
if self._googleapis_discovery:
return self._googleapis_discovery

if LOCAL_GOOGLEAPIS_DISCOVERY:
self._googleapis_discovery = Path(LOCAL_GOOGLEAPIS_DISCOVERY).expanduser()
logger.debug(
f"Using local googleapis-discovery at {self._googleapis_discovery}"
)

else:
logger.debug("Cloning googleapis-discovery.")
self._googleapis_discovery = git.clone(GOOGLEAPIS_DISCOVERY_URL)

return self._googleapis_discovery

def _clone_discovery_artifact_manager(self):
if self._discovery_artifact_manager:
return self._discovery_artifact_manager
Expand Down