Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.22.5 image tag is missing #79

Closed
rootulp opened this issue Aug 21, 2024 · 7 comments
Closed

v1.22.5 image tag is missing #79

rootulp opened this issue Aug 21, 2024 · 7 comments

Comments

@rootulp
Copy link

rootulp commented Aug 21, 2024

Context

The v1.22.5 image tag is missing from https://github.com/goreleaser/goreleaser-cross/pkgs/container/goreleaser-cross/versions?filters%5Bversion_type%5D=tagged

Problem

Our repo upgrades Golang versions regularly and it is a maintenance burden to check if the relevant goreleaser-cross image version exists.

Proposal

Create a goreleaser-cross image tag for every Go release.

@troian
Copy link
Member

troian commented Aug 21, 2024

i'll release it in a next day or two, have to do it manually as gh actions runners always fails due to no space issue.
you can use v1.22.6 tho

@rootulp
Copy link
Author

rootulp commented Aug 22, 2024

Thanks yea we worked around the issue by bumping to Go 1.22.6 in celestiaorg/celestia-app#3803 but we can't get pre-built binaries attached to the original release because we can't modify CI on that release. I cut a subsequent release and hit a different goreleaser problem here 🤦‍♂️

@rootulp
Copy link
Author

rootulp commented Aug 22, 2024

We stopped using a deprecated field in celestiaorg/celestia-app#3795 but it looks like goreleaser-cross just bumped to goreleaser v2.2.0 in 239cf40 so we need to bump to that

@qwqcode
Copy link
Contributor

qwqcode commented Sep 8, 2024

golang 1.22.7 has also been released, which fixes security issues

@troian
Copy link
Member

troian commented Sep 9, 2024

1.22.7 released

@troian troian closed this as completed Sep 9, 2024
@caarlos0
Copy link
Member

fwiw this replaced :latest as well it seems

@caarlos0
Copy link
Member

caarlos0 commented Sep 12, 2024

running this to fix:

  for name in goreleaser-cross-base goreleaser-cross goreleaser-cross-pro
          for registry in ghcr.io docker.io
                  docker pull $registry/goreleaser/$name:v1.23.1
                  docker tag $registry/goreleaser/$name:v1.23.1 $registry/goreleaser/$name:latest
                  docker push $registry/goreleaser/$name:latest
              end
  end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants