Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prebuilt binaries for v2.1.0 don't exist #3802

Closed
rootulp opened this issue Aug 21, 2024 · 2 comments
Closed

Prebuilt binaries for v2.1.0 don't exist #3802

rootulp opened this issue Aug 21, 2024 · 2 comments
Assignees
@rootulp
Labels
bug Something isn't working WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc

Comments

@rootulp
Copy link
Collaborator

rootulp commented Aug 21, 2024

Context

Goreleaser failed: https://github.com/celestiaorg/celestia-app/actions/runs/10486700729/job/29045516449

Unable to find image 'ghcr.io/goreleaser/goreleaser-cross:v1.22.5' locally

That image tag appears missing from https://github.com/goreleaser/goreleaser-cross/pkgs/container/goreleaser-cross/versions?filters%5Bversion_type%5D=tagged

Proposal

Fix the Goreleaser issue and re-trigger so that we get prebuilt binaries attached to v2.1.0
@rootulp rootulp added bug Something isn't working WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc labels Aug 21, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Aug 21, 2024 •
edited
Loading

Created goreleaser/goreleaser-cross#79. I don't see a way to create prebuilt binaries (via CI) on the v2.1.0 release unless goreleaser-cross creates a tagged image and we retry CI after that.

We can workaround by backporting #3764 to v2.x and then creating a v2.1.1. That should work because there is a goreleaser-cross v1.22.6 tag.

@rootulp rootulp self-assigned this Aug 21, 2024
@rootulp rootulp mentioned this issue Aug 21, 2024
Merged
rootulp added a commit that referenced this issue Aug 21, 2024
@mergify @rootulp
chore(deps): upgrade to Go 1.22.6 (backport #3764) (#3803)
e7a4b51 
Backport #3764 so that we can work around
#3802. If we cut a
v2.1.1 then pre-built binaries should work because a goreleaser-cross
image tag exists for Go 1.22.6

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
@rootulp
Copy link
Collaborator Author

rootulp commented Aug 26, 2024

Fixed this issue by upgrading to goreleaser-cross v1.22.6 tag.

@rootulp rootulp closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
bug Something isn't working WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp