Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support logger for print stack trace #195

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Support logger for print stack trace #195

merged 1 commit into from
Aug 22, 2020

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Aug 22, 2020 •
edited
Loading

Fixes #171

Summary of Changes

  1. Use logger if available for stack trace. If not, we will still print stacktrace to stdout as usual.

PS: Make sure your PR includes/updates tests! If you need help with this part, just ask!

@sayboras sayboras mentioned this pull request Aug 22, 2020
Closed
@elithrar elithrar self-assigned this Aug 22, 2020
@elithrar elithrar self-requested a review August 22, 2020 19:31
@elithrar elithrar merged commit d6944a4 into gorilla:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elithrar elithrar elithrar approved these changes

Assignees

@elithrar elithrar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Ability to print stack trace as log
2 participants
@sayboras @elithrar