Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golden: accept -update for updating files #235

Merged
merged 1 commit into from
May 3, 2022

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented May 1, 2022

The -test.update-golden flag is long enough that it can be a challenge for people to remember, especially when golden files are not updated frequently. I've seen other implementations of this pattern use just the -update flag, which was easier to remember.

This PR keeps support for the existing -test.update-golden flag, but also adds -update as an option for updating golden files.

In the future there could be other auto-update operations that could make use of this same flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants