fix: set common UI env vars regardless of whether a file is passed #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
njhale,
StrongMonkey,
g-linville and
tylerslaton
g-linville
reviewed
Jul 15, 2024
Comment on lines
-376
to
-378
| if len(args) > 2 { | ||
| args = append(args, args[2:]...) | ||
| } |
There was a problem hiding this comment.
Is this piece no longer needed? Just want to make sure its removal is not accidental.
There was a problem hiding this comment.
I did intend to remove it. The original intention of this code was to remove the file from the args and keep the remaining args. I have added logic to this PR for the same purpose.
Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
force-pushed
the
set-ui-env-vars
branch
from
c1a74ce
to
904e97f
Compare
njhale
approved these changes
Jul 15, 2024
g-linville
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.