fix: use default config in embedded SDK server #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/sdkserver/server.go
Outdated
| @@ -56,6 +56,8 @@ func Run(ctx context.Context, opts Options) error { | |||
| // EmbeddedStart allows running the server as an embedded process that may use Stdin for input. | |||
| // It returns the address the server is listening on. | |||
| func EmbeddedStart(ctx context.Context, opts Options) (string, error) { | |||
There was a problem hiding this comment.
why you no like my variadic approach :( I love doing opts ...Options now. It's so nicely composable.
There was a problem hiding this comment.
I can update that.
Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
force-pushed
the
default-config-embed-sdk
branch
from
a013b20
to
13c31fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.