Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: "share tools:" should support all tool types, not just tool #839

Merged
merged 1 commit into from
Sep 6, 2024
Merged

bug: "share tools:" should support all tool types, not just tool #839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion pkg/types/tool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,13 +602,27 @@ func (t Tool) GetToolsByType(prg *Program, toolType ToolType) ([]ToolReference,
case ToolTypeInput:
exportRefs = tool.ExportInputFilters
case ToolTypeTool:
exportRefs = tool.Export
case ToolTypeCredential:
exportRefs = tool.ExportCredentials
default:
return nil, fmt.Errorf("unknown tool type %v", toolType)
}
toolSet.AddAll(tool.GetToolRefsFromNames(exportRefs))

toolRefs, err := tool.GetToolRefsFromNames(tool.Export)
if err != nil {
return nil, err
}

for _, toolRef := range toolRefs {
tool, ok := prg.ToolSet[toolRef.ToolID]
if !ok {
continue
}
if slices.Contains(toolsListFilterType, tool.Type) {
toolSet.Add(toolRef)
}
}
}

return toolSet.List()
Expand Down