Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add closeStagingRepositories and releaseStagingRepositories summary tasks (#236) #285

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Nov 23, 2023

Fixes #236

Copy link
Contributor

@szpak szpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

I agree that they might be useful. I believe, there was a similar discussion years ago and (AFAIR) the main argument against, given by someone, was increased number of tasks (to quickly understand what should be used for new users) and a chance to (try to) accidentally close "too many" repositories.

While the first one might be some problem for newcomers, more experiences users could be happy having them. In the second case, I think that having 2+ repositories configured requires some "knowledge" about Gradle and people should be aware of the pitfalls.

Wrapping up, I'm ok for that contribution as it is more a matter of taste. @TWiStErRob How do you see it?

Btw, @Vampire it would be good to have them mentioned in README to make people more aware of that "simplification".

Copy link
Collaborator

@TWiStErRob TWiStErRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like lifecycle/convenience tasks if they're well documented, which seems to be the case (descriptions and groups are clear, naming could be improved).

@Vampire Vampire force-pushed the issue-236 branch 2 times, most recently from 8573062 to a2787c1 Compare November 26, 2023 11:45
@szpak
Copy link
Contributor

szpak commented Nov 26, 2023

Thanks @Vampire (also for using the textBlock). Rebased with master and force pushed.

@TWiStErRob How do you like it?

Copy link
Collaborator

@TWiStErRob TWiStErRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, sorry for the wait.

I think it ended being nice and clean. Looks reasonable to me.

These's one final nit: the title of the PR (and therefore the commit on master) needs -ies, right?

@Vampire Vampire changed the title Add closeStagingRepository and releaseStagingRepository summary tasks (#236) Add closeStagingRepositories and releaseStagingRepositories summary tasks (#236) Dec 3, 2023
@Vampire
Copy link
Contributor Author

Vampire commented Dec 3, 2023

Absolutely, thanks.
Fixed both, commit message and PR title

@szpak szpak added this pull request to the merge queue Dec 3, 2023
@szpak
Copy link
Contributor

szpak commented Dec 3, 2023

Thanks again, merged.

Btw, using the merge queue makes it problematic to change the squash commit message :-/

Merged via the queue into gradle-nexus:master with commit 381ab45 Dec 3, 2023
6 checks passed
@Vampire Vampire deleted the issue-236 branch December 3, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin DSL friendly overall tasks
3 participants