-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add closeStagingRepositories and releaseStagingRepositories summary tasks (#236) #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
I agree that they might be useful. I believe, there was a similar discussion years ago and (AFAIR) the main argument against, given by someone, was increased number of tasks (to quickly understand what should be used for new users) and a chance to (try to) accidentally close "too many" repositories.
While the first one might be some problem for newcomers, more experiences users could be happy having them. In the second case, I think that having 2+ repositories configured requires some "knowledge" about Gradle and people should be aware of the pitfalls.
Wrapping up, I'm ok for that contribution as it is more a matter of taste. @TWiStErRob How do you see it?
Btw, @Vampire it would be good to have them mentioned in README to make people more aware of that "simplification".
src/test/kotlin/io/github/gradlenexus/publishplugin/TaskOrchestrationTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/io/github/gradlenexus/publishplugin/TaskOrchestrationTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like lifecycle/convenience tasks if they're well documented, which seems to be the case (descriptions and groups are clear, naming could be improved).
src/test/kotlin/io/github/gradlenexus/publishplugin/TaskOrchestrationTest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/github/gradlenexus/publishplugin/NexusPublishPlugin.kt
Show resolved
Hide resolved
src/main/kotlin/io/github/gradlenexus/publishplugin/NexusPublishPlugin.kt
Outdated
Show resolved
Hide resolved
8573062
to
a2787c1
Compare
Thanks @Vampire (also for using the @TWiStErRob How do you like it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience, sorry for the wait.
I think it ended being nice and clean. Looks reasonable to me.
These's one final nit: the title of the PR (and therefore the commit on master
) needs -ies
, right?
Absolutely, thanks. |
Thanks again, merged. Btw, using the merge queue makes it problematic to change the squash commit message :-/ |
Fixes #236