Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate wrappers for all Gradle nightlies published at https://services.gradle.org/distributions-snapshots/ #281

Closed
eskatos opened this issue Jan 15, 2020 · 4 comments
Labels
Milestone

Comments

@eskatos
Copy link
Member

eskatos commented Jan 15, 2020

This is a prerequisite for using the action in any repository that makes use of nightlies.

This is a prerequisite for dogfooding in the gradle org which makes heavy use of nightlies.

Currently, the action consumes https://services.gradle.org/versions/all which contains information about the latest nightly and the latest release nightly only. All other nightlies are missing.

@3flex
Copy link
Contributor

3flex commented Jul 22, 2024

The services.gradle.org versions API only provides details on latest nightly (and release nightly), so wouldn't the API need to be enhanced first? Is there another source for this?

@bigdaz
Copy link
Member

bigdaz commented Jul 22, 2024

While not ideal, it should be possible to extract the wrapper checksums by traversing the directory listing at https://services.gradle.org/distributions-snapshots/

@3flex
Copy link
Contributor

3flex commented Jul 22, 2024

Do you mean by reading the HTML and looking for the links? Or is there another way? I'd have thought that would be a little fragile, and failures to parse would have to fail the action if validation has been enabled (though given it's for nightlies failures are relatively lower impact, and any issue would surely be fixed quickly especially if it's impacting Gradle's own builds).

I'm not volunteering to build a PR since I'm unfamiliar with TypeScript but the pointers might help someone with the right experience. It would be nice to unblock #12 for v4.

@bigdaz
Copy link
Member

bigdaz commented Jul 22, 2024

Yes, that's what I meant. The HTML is a generated directory listing and should be generally stable over time.

We would only fail the build if all of the following were true:

I think this would be acceptable.

I'm not sure about getting #14 into v4, but you're right that it would be nice.
I now wish I'd released v4.0.0-beta.1 instead of going straight to an RC!

@bigdaz bigdaz added this to the v4.0.0 milestone Jul 22, 2024
bigdaz added a commit that referenced this issue Jul 31, 2024
By slurping the checksum URLs from https://services.gradle.org/distributions-snapshots/
we can include these unpublished wrapper checksums in validation.

Fixes #281
@bigdaz bigdaz closed this as completed in 7179909 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@eskatos @3flex @bigdaz and others