Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep for v0.30.2 #2723

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Prep for v0.30.2 #2723

merged 5 commits into from
Jan 11, 2023

Commits on Jan 11, 2023

  1. prometheus.relabel: clone labels before relabeling (grafana#2701) 

    This commit clones the label set before applying relabels. Not
cloning does two things:

1. It forces the computed ID of the incoming series to change (as its
   labels changed)

2. It can cause obscure bugs with relabel rules being applied, such as
   a `keep` action which doesn't work after modifying the original
   slice.
    @rfratto
    rfratto committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    6931717 View commit details
    Browse the repository at this point in the history

  2. component/common/loki: drop unqueued logs after 5 seconds on shutdown (… 

    …grafana#2721)

Fix an issue where being unable to send logs to `loki.write` due to the
client being permanently backlogged would deadlock the Flow controller.

The `loki.write` client may be permanently backlogged when:

* Limits are reached when sending logs to Loki, leading to endless
  request retries.
* Loki has an extended outage.

When an EntryHandler is stopped, it will wait for 5 seconds before
forcibly stopping the goroutine which queues log entries. If this
timeout is reached, any unqueued log entries are permanently lost, as
the positions file will likely be updated past the point where the entry
was read.

While losing logs is not ideal, it's unacceptable for any Flow component
to be able to block the controller. This is a short-term solution to
allow the Flow controller to continue working properly. A long term
solution would be to use a Write-Ahead Log (WAL) for log entries. See
grafana/loki#7993.

Fixes grafana#2716.
Related to grafana/loki#2361.
    @rfratto
    rfratto committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    7dd11e2 View commit details
    Browse the repository at this point in the history

  3. prepare for v0.30.2 release

    @rfratto
    rfratto committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    60aa7e7 View commit details
    Browse the repository at this point in the history

  4. address review feedback

    @rfratto
    rfratto committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    94096e5 View commit details
    Browse the repository at this point in the history

  5. operator: Use enableHttp2 field as boolean in libsonnet templates (gr… 

    …afana#2724)

Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
    @tpaschalis @rfratto
    tpaschalis authored and rfratto committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    fe5a9e7 View commit details
    Browse the repository at this point in the history