Merge pull request #290 from grafana/fix-unhealthy-pods-in-rollout-da…

…shboard Fix 'Unhealthy pods' in Cortex Rollout dashboard
grafana · Apr 7, 2021 · b8d293a · b8d293a
2 parents a8dc588 + 5516a8c
commit b8d293a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## master / unreleased
 
-* [FEATURE] Added "Cortex / Rollout progress" dashboard. #289
+* [FEATURE] Added "Cortex / Rollout progress" dashboard. #289 #290
 * [ENHANCEMENT] Added `newCompactorStatefulSet()` function to create a custom statefulset for the compactor. #287
 * [ENHANCEMENT] Added option to configure compactor job name used in dashboards and alerts. #287
 * [BUGFIX] Fixed `CortexCompactorRunFailed` false positives. #288

diff --git a/cortex-mixin/dashboards/dashboard-utils.libsonnet b/cortex-mixin/dashboards/dashboard-utils.libsonnet
@@ -173,7 +173,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
       tooltip: { sort: 2 },  // Sort descending.
     },
 
-  newStatPanel(queries, legends='', unit='percentunit', thresholds=[], instant=false, novalue='')::
+  newStatPanel(queries, legends='', unit='percentunit', decimals=1, thresholds=[], instant=false, novalue='')::
     super.queryPanel(queries, legends) + {
       type: 'stat',
       targets: [
@@ -191,7 +191,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
       fieldConfig: {
         defaults: {
           color: { mode: 'thresholds' },
-          decimals: 1,
+          decimals: decimals,
           thresholds: {
             mode: 'absolute',
             steps: thresholds,

diff --git a/cortex-mixin/dashboards/rollout-progress.libsonnet b/cortex-mixin/dashboards/rollout-progress.libsonnet
@@ -177,7 +177,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
           { color: 'green', value: null },
           { color: 'orange', value: 1 },
           { color: 'red', value: 2 },
-        ], instant=true, novalue='All healthy') + {
+        ], instant=true, novalue='All healthy', unit='short', decimals=0) + {
           options: {
             text: {
               // Small font size since we may have many entries during a rollout.