Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Alertmanager HA #147

Merged
merged 6 commits into from
Sep 4, 2020
Merged

Support Alertmanager HA #147

merged 6 commits into from
Sep 4, 2020

Conversation

gotjosh
Copy link
Contributor

@gotjosh gotjosh commented Jul 24, 2020

With this, we can now support increasing the number of replicas for a
Cortex AM thus enabling HA.

Please note that Alerts themselves are not gossiped between
Alertmanagers. Each Ruler needs to send the alert to every Alertmanager
available thus the reason why a headless service gets created when the
number of replicas is more than 1.

@gotjosh gotjosh requested a review from a team as a code owner July 24, 2020 15:00
@gotjosh gotjosh requested a review from jtlisi July 24, 2020 15:01
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -227,6 +227,11 @@
},
}[$._config.ruler_client_type],

alertmanager: {
replicas: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still going to default to 1 replica?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, can we bump this to 3?

@gotjosh gotjosh requested a review from gouthamve August 21, 2020 11:15
With this, we can now support increasing the number of replicas for a
Cortex AM thus enabling HA.

 Please note that Alerts themselves are not gossiped between
Alertmanagers. Each Ruler needs to send the alert to every Alertmanager
available thus the reason why a headless service gets created when the
number of replicas is more than 1.
@gotjosh gotjosh merged commit 5ec0459 into master Sep 4, 2020
@gotjosh gotjosh deleted the support-am-ha branch September 4, 2020 13:06
simonswine pushed a commit to grafana/mimir that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants