Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposes ruler queries for reuse #169

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Aug 26, 2020

This extracts the ruler dashboard queries into a hidden field which can then be referenced. This is attractive for Loki in particular which wants to reuse the queries to monitor its ruler (built upon cortex). This is a noop.

Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d requested a review from a team as a code owner August 26, 2020 15:29
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As they are, these dashboards are not really all that useful 😭 .

It's on my agenda to create more graphs that help us spot iffy things more quickly - but it's currently at the bottom of my priorities. Let me know if you plan to do more work here and I'll be happy to run you through what I'm thinking.

@owen-d owen-d merged commit 9491dfb into grafana:master Aug 26, 2020
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
…pose-ruler-queries

exposes ruler queries for reuse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants