Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingester-blocks to ingester's job label matcher #203

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

pracucci
Copy link
Collaborator

What this PR does:
When we migrate a Cortex cluster from chunks to blocks, the migration procedure involves creating a temporary statefulset named ingester-blocks. Because of this, during the migration we loose visibility over ingesters.

What's the sentiment adding ingester-blocks too to default job names?

Which issue(s) this PR fixes:
N/A

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from a team as a code owner October 14, 2020 14:42
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
@pracucci pracucci merged commit 30cc219 into master Oct 27, 2020
@pracucci pracucci deleted the match-blocks-ingesters-too branch October 27, 2020 13:40
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
…ks-ingesters-too

Add ingester-blocks to ingester's job label matcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants