Added more critical alerts on Cortex ingester TSDB #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codesome
reviewed
Oct 29, 2020
codesome
reviewed
Oct 29, 2020
codesome
reviewed
Oct 29, 2020
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-tsdb-critical-alerts
branch
from
5eb23ea
to
1959732
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
codesome
approved these changes
Nov 10, 2020
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…onnet#208) * Added more critical alerts on Cortex ingester TSDB Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Addressed review comments Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the last few days we experienced TSDB WAL corruption twice and we found the alerts to not be adequate. In this PR I'm proposing to add more critical alerts in TSDB possible issue, including the usage of new metrics introduced in cortexproject/cortex#3373.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]